Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify regex and add tests #268

Merged
merged 2 commits into from
Nov 1, 2020

Conversation

luo-git
Copy link

@luo-git luo-git commented Oct 31, 2020

Resolve #229

@codecov-io
Copy link

codecov-io commented Oct 31, 2020

Codecov Report

Merging #268 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #268   +/-   ##
=========================================
  Coverage     64.44%   64.44%           
  Complexity      550      550           
=========================================
  Files           100      100           
  Lines          1817     1817           
  Branches        189      189           
=========================================
  Hits           1171     1171           
  Misses          572      572           
  Partials         74       74           
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/model/tag/FileAddress.java 61.53% <ø> (ø) 8.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 293a9ed...c1121e5. Read the comment docs.

Copy link

@Ma-Yueran Ma-Yueran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luo-git luo-git merged commit 6f22402 into AY2021S1-CS2103T-F12-1:master Nov 1, 2020
@luo-git luo-git added this to the v1.4 milestone Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D] Valid special character in file path not recognised
3 participants