-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indicate clearly which actions can be undone, redone #269
Conversation
Codecov Report
@@ Coverage Diff @@
## master #269 +/- ##
=========================================
Coverage 64.42% 64.42%
Complexity 550 550
=========================================
Files 100 100
Lines 1816 1816
Branches 189 189
=========================================
Hits 1170 1170
Misses 572 572
Partials 74 74
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There's just some minor opinion about the changes.
@@ -18,6 +18,14 @@ | |||
public static final String COMMAND_WORD = "redo"; | |||
public static final String REDO_COMMAND_USAGE = COMMAND_WORD; | |||
public static final String MESSAGE_USAGE = COMMAND_WORD + ": Redo the recent command. " | |||
+ "\nCommands that can be redone:" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about this, but is it neccessary to list the commands, that could be redone? Since redo only exist when undo is executed right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure some troller gonna ask, might as well put it in, since this only shows when you type help redo right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Resolve #251
Resolve #250