Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate clearly which actions can be undone, redone #269

Merged
merged 2 commits into from
Nov 1, 2020

Conversation

li-s
Copy link

@li-s li-s commented Nov 1, 2020

Resolve #251
Resolve #250

@codecov-io
Copy link

Codecov Report

Merging #269 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #269   +/-   ##
=========================================
  Coverage     64.42%   64.42%           
  Complexity      550      550           
=========================================
  Files           100      100           
  Lines          1816     1816           
  Branches        189      189           
=========================================
  Hits           1170     1170           
  Misses          572      572           
  Partials         74       74           
Impacted Files Coverage Δ Complexity Δ
...java/seedu/address/logic/commands/RedoCommand.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
...java/seedu/address/logic/commands/UndoCommand.java 100.00% <ø> (ø) 4.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c73e87b...d308615. Read the comment docs.

Copy link

@HynRidge HynRidge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
There's just some minor opinion about the changes.

@@ -18,6 +18,14 @@
public static final String COMMAND_WORD = "redo";
public static final String REDO_COMMAND_USAGE = COMMAND_WORD;
public static final String MESSAGE_USAGE = COMMAND_WORD + ": Redo the recent command. "
+ "\nCommands that can be redone:"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this, but is it neccessary to list the commands, that could be redone? Since redo only exist when undo is executed right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure some troller gonna ask, might as well put it in, since this only shows when you type help redo right.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay then

@li-s li-s requested a review from HynRidge November 1, 2020 07:13
Copy link

@HynRidge HynRidge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@li-s li-s merged commit 798613a into AY2021S1-CS2103T-F12-1:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants