Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Default theme to Light theme #271

Conversation

Ma-Yueran
Copy link

The name of the previous Default theme is changed to be Light theme, so making Dark Theme the default theme is no longer an error.

@codecov-io
Copy link

Codecov Report

Merging #271 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #271   +/-   ##
=========================================
  Coverage     64.42%   64.42%           
  Complexity      550      550           
=========================================
  Files           100      100           
  Lines          1816     1816           
  Branches        189      189           
=========================================
  Hits           1170     1170           
  Misses          572      572           
  Partials         74       74           
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/ui/ThemeWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/theme/ThemeSet.java 83.33% <100.00%> (ø) 3.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 798613a...348e9a2. Read the comment docs.

Copy link

@luo-git luo-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ma-Yueran Ma-Yueran merged commit ea1eec5 into AY2021S1-CS2103T-F12-1:master Nov 2, 2020
@Ma-Yueran Ma-Yueran added this to the v1.4 milestone Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D] Inaccurate UI picture in UG [PE-D] Default theme is set to dark theme, not default (light) theme
3 participants