Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Themes for UI #276

Merged
merged 7 commits into from
Nov 4, 2020

Conversation

Ma-Yueran
Copy link

Galaxy Theme:
galaxy_theme
Sky Theme (Cannot think of a better name...)
sky_theme

@codecov-io
Copy link

codecov-io commented Nov 3, 2020

Codecov Report

Merging #276 into master will decrease coverage by 0.06%.
The diff coverage is 36.36%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #276      +/-   ##
============================================
- Coverage     64.17%   64.11%   -0.07%     
- Complexity      550      552       +2     
============================================
  Files           100      100              
  Lines          1823     1831       +8     
  Branches        192      192              
============================================
+ Hits           1170     1174       +4     
- Misses          578      582       +4     
  Partials         75       75              
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/ui/ThemeWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/theme/ThemeSet.java 90.00% <100.00%> (+6.66%) 5.00 <0.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 743e879...acfff08. Read the comment docs.

Copy link

@luo-git luo-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The words in galaxy theme is a bit hard to read though.

Another thing, could you update the UG as well?

@Ma-Yueran
Copy link
Author

Looks good. The words in galaxy theme is a bit hard to read though.

Another thing, could you update the UG as well?

Sure, I try to add theme switching to UG

@Ma-Yueran
Copy link
Author

Looks good. The words in galaxy theme is a bit hard to read though.
Another thing, could you update the UG as well?

Sure, I try to add theme switching to UG

Ooo, just found it's already added, then I will update the images.

@luo-git
Copy link

luo-git commented Nov 4, 2020

Looks good. The words in galaxy theme is a bit hard to read though.
Another thing, could you update the UG as well?

Sure, I try to add theme switching to UG

Ooo, just found it's already added, then I will update the images.

The changing theme section is not updated to reflect your changes. Could you also update the screenshot if possible?

Changing themes
HelloFile comes in light and dark themes. ...

@Ma-Yueran
Copy link
Author

Looks good. The words in galaxy theme is a bit hard to read though.
Another thing, could you update the UG as well?

Sure, I try to add theme switching to UG

Ooo, just found it's already added, then I will update the images.

The changing theme section is not updated to reflect your changes. Could you also update the screenshot if possible?

Changing themes
HelloFile comes in light and dark themes. ...

Sure, I'm doing that now

@Ma-Yueran
Copy link
Author

The color of the edge of the window for me is white,
changing_themes2

But others are blue,
changing_themes

How do I modify the color to make it consistent?

@Ma-Yueran
Copy link
Author

Galaxy Theme is updated to make fonts clearer,
Uploading galaxy_theme.png…

@luo-git
Copy link

luo-git commented Nov 4, 2020

How do I modify the color to make it consistent?

Doesn't matter for now. We probably need to change those screenshots later because the words are too small...😢

Copy link

@luo-git luo-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ma-Yueran Ma-Yueran merged commit f166ab9 into AY2021S1-CS2103T-F12-1:master Nov 4, 2020
@Ma-Yueran Ma-Yueran added this to the v1.4 milestone Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants