-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add New Themes for UI #276
Add New Themes for UI #276
Conversation
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
============================================
- Coverage 64.17% 64.11% -0.07%
- Complexity 550 552 +2
============================================
Files 100 100
Lines 1823 1831 +8
Branches 192 192
============================================
+ Hits 1170 1174 +4
- Misses 578 582 +4
Partials 75 75
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The words in galaxy theme is a bit hard to read though.
Another thing, could you update the UG as well?
…into branch-new-theme
Sure, I try to add theme switching to UG |
Ooo, just found it's already added, then I will update the images. |
The Changing themes |
Sure, I'm doing that now |
Doesn't matter for now. We probably need to change those screenshots later because the words are too small...😢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Galaxy Theme:
Sky Theme (Cannot think of a better name...)