Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Model test cases for FileAddress, AddressBook #285

Merged
merged 8 commits into from
Nov 7, 2020

Conversation

HynRidge
Copy link

@HynRidge HynRidge commented Nov 6, 2020

Test Cases added for FileAddress.java , AddressBook.java, and some more

@luo-git luo-git changed the title Update Logic test cases for FileAddress, AddressBook Update Model test cases for FileAddress, AddressBook Nov 6, 2020
Copy link

@luo-git luo-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good test cases. Can improve by making some changes.

src/test/java/seedu/address/model/AddressBookTest.java Outdated Show resolved Hide resolved
src/test/java/seedu/address/model/AddressBookTest.java Outdated Show resolved Hide resolved
src/test/java/seedu/address/model/AddressBookTest.java Outdated Show resolved Hide resolved
src/test/java/seedu/address/model/AddressBookTest.java Outdated Show resolved Hide resolved
src/test/java/seedu/address/model/label/LabelTest.java Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Nov 6, 2020

Codecov Report

Merging #285 (c72d193) into master (283b3f7) will increase coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #285      +/-   ##
============================================
+ Coverage     66.50%   67.04%   +0.54%     
- Complexity      575      582       +7     
============================================
  Files           100      100              
  Lines          1836     1836              
  Branches        195      195              
============================================
+ Hits           1221     1231      +10     
+ Misses          536      529       -7     
+ Partials         79       76       -3     
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/model/AddressBook.java 92.59% <0.00%> (+11.11%) 14.00% <0.00%> (+1.00%)
...main/java/seedu/address/model/tag/FileAddress.java 76.92% <0.00%> (+15.38%) 11.00% <0.00%> (+3.00%)
...ddress/model/tag/TagNameContainsCharPredicate.java 100.00% <0.00%> (+16.66%) 6.00% <0.00%> (+1.00%)
src/main/java/seedu/address/model/label/Label.java 89.47% <0.00%> (+21.05%) 10.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 283b3f7...c72d193. Read the comment docs.

Copy link

@luo-git luo-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍

@luo-git luo-git merged commit dcfbf65 into AY2021S1-CS2103T-F12-1:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants