Update CliSyntax to match HelloFile #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PREFIX_TAG_NAME = "t/" PREFIX_OLD_TAG_NAME = "o/" PREFIX_FILE_ADDRESS = "f/" PREFIX_COMMAND = "c/"
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
============================================
+ Coverage 57.46% 57.50% +0.03%
Complexity 329 329
============================================
Files 70 70
Lines 1192 1193 +1
Branches 92 92
============================================
+ Hits 685 686 +1
Misses 480 480
Partials 27 27
Continue to review full report at Codecov.
|
li-s
approved these changes
Oct 10, 2020
| @@ -25,7 +26,8 @@ | |||
| */ | |||
| public AddCommand parse(String args) throws ParseException { | |||
| ArgumentMultimap argMultimap = | |||
| ArgumentTokenizer.tokenize(args, PREFIX_TAG_NAME, PREFIX_FILE_ADDRESS, PREFIX_TAG); | |||
| ArgumentTokenizer.tokenize(args, PREFIX_TAG_NAME, PREFIX_FILE_ADDRESS, | |||
| PREFIX_OLD_TAG_NAME, PREFIX_COMMAND); | |||
There was a problem hiding this comment.
Does add command parser need prefix_old_tag_name? Isn't the command tag f/filepath t/tagname?
|
LGTM, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PREFIX_TAG_NAME = "t/"
PREFIX_OLD_TAG_NAME = "o/"
PREFIX_FILE_ADDRESS = "f/"
PREFIX_COMMAND = "c/"