Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify DeleteCommand, DeleteParser to UntagCommand, UntagParser #84

Merged
merged 2 commits into from
Oct 10, 2020

Conversation

li-s
Copy link

@li-s li-s commented Oct 10, 2020

Resolve #53

@li-s li-s requested a review from luo-git October 10, 2020 11:24
@codecov-io
Copy link

Codecov Report

Merging #84 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #84   +/-   ##
=========================================
  Coverage     57.50%   57.50%           
  Complexity      329      329           
=========================================
  Files            70       70           
  Lines          1193     1193           
  Branches         92       92           
=========================================
  Hits            686      686           
  Misses          480      480           
  Partials         27       27           
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ava/seedu/address/logic/commands/UntagCommand.java 100.00% <100.00%> (ø) 7.00 <1.00> (?)
.../seedu/address/logic/parser/AddressBookParser.java 100.00% <100.00%> (ø) 11.00 <0.00> (ø)
...seedu/address/logic/parser/UntagCommandParser.java 100.00% <100.00%> (ø) 2.00 <1.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a06e2d...fa61628. Read the comment docs.

Copy link

@luo-git luo-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luo-git luo-git merged commit ade0a6b into AY2021S1-CS2103T-F12-1:master Oct 10, 2020
@luo-git luo-git linked an issue Oct 10, 2020 that may be closed by this pull request
@anthony6401 anthony6401 added this to the v1.2 milestone Oct 14, 2020
@li-s li-s deleted the branch-untagCommand branch October 20, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify DeleteCommand and DeleteParser into UntagCommand and UntagParser
4 participants