Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify AddCommand AddCommandParser to TagCommand and TagCommandParser #86

Merged
merged 3 commits into from
Oct 11, 2020
Merged

Modify AddCommand AddCommandParser to TagCommand and TagCommandParser #86

merged 3 commits into from
Oct 11, 2020

Conversation

luo-git
Copy link

@luo-git luo-git commented Oct 10, 2020

Also switches to the new UI.

Resolves #48

@luo-git luo-git requested a review from HynRidge October 10, 2020 15:10
@luo-git luo-git added this to the v1.2 milestone Oct 10, 2020
@luo-git luo-git added the priority.High Must do label Oct 10, 2020
@codecov-io
Copy link

codecov-io commented Oct 10, 2020 •
edited

Codecov Report

Merging #86 into master will not change coverage.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #86   +/-   ##
=========================================
  Coverage     57.50%   57.50%           
  Complexity      329      329           
=========================================
  Files            70       70           
  Lines          1193     1193           
  Branches         92       92           
=========================================
  Hits            686      686           
  Misses          480      480           
  Partials         27       27
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/Main.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/main/java/seedu/address/logic/parser/Prefix.java 91.66% <ø> (ø) 7.00 <0.00> (ø)
...main/java/seedu/address/model/tag/FileAddress.java 80.00% <ø> (ø) 6.00 <0.00> (ø)
.../java/seedu/address/logic/commands/TagCommand.java 100.00% <100.00%> (ø) 8.00 <2.00> (?)
.../seedu/address/logic/parser/AddressBookParser.java 100.00% <100.00%> (ø) 11.00 <0.00> (ø)
...a/seedu/address/logic/parser/TagCommandParser.java 100.00% <100.00%> (ø) 5.00 <1.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ade0a6b...45acc72. Read the comment docs.

Ma-Yueran
Ma-Yueran approved these changes Oct 10, 2020
View reviewed changes
Copy link

@Ma-Yueran Ma-Yueran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

src/test/java/seedu/address/logic/LogicManagerTest.java Show resolved Hide resolved
li-s
li-s requested changes Oct 11, 2020
View reviewed changes
Copy link

@li-s li-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM

src/test/java/seedu/address/logic/commands/TagCommandIntegrationTest.java Outdated Show resolved Hide resolved
@li-s li-s merged commit f8a20e7 into AY2021S1-CS2103T-F12-1:master Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@li-s li-s li-s approved these changes

@Ma-Yueran Ma-Yueran Ma-Yueran approved these changes

@HynRidge HynRidge Awaiting requested review from HynRidge

Assignees
No one assigned
Labels
priority.High Must do
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

Modify AddCommand AddCommandParser to TagCommand and TagCommandParser
4 participants
@luo-git @codecov-io @li-s @Ma-Yueran