Implement ContactList to encapsulate Contact related objects and methods #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasngs
added
type.Task
…into branch-contact-list
michael-setia
approved these changes
Oct 17, 2020
|
|
||
| contactList.setContact(target, editedContact); | ||
| } | ||
|
|
||
| //=========== Filtered Module List Accessors ============================================================= |
There was a problem hiding this comment.
I think we can create sections for the accessor methods for each type of list? Since there are going to be todolist and possibly schedule list also. Just to make things more organized 😃
There was a problem hiding this comment.
Yes this will be done!
| setContact(newData.getContactList()); | ||
| } | ||
|
|
||
| //// person-level operations |
There was a problem hiding this comment.
Maybe can change "person" to "contact"?
There was a problem hiding this comment.
Yes will change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #225
This PR implements a ContactList class to encapsulate Contact related objects and methods. Additionally, this new ContactList object has been added as a field of the ModelManager class which will be responsible for managing the ContactList class and all methods that relate to ContactList.
Junit tests that test ModelManager have been temporarily commented out.