-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement find contact command for ContactList #257
Implement find contact command for ContactList #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation is similar with the rest of the code. Overall, looks great to merge 👍
Codecov Report
@@ Coverage Diff @@
## master #257 +/- ##
============================================
- Coverage 28.49% 26.73% -1.76%
+ Complexity 312 308 -4
============================================
Files 138 143 +5
Lines 2218 2334 +116
Branches 249 261 +12
============================================
- Hits 632 624 -8
- Misses 1532 1655 +123
- Partials 54 55 +1
Continue to review full report at Codecov.
|
Fixes #240
This PR relates to the implementation of a command to find a contact in the ContactList by name, following the earlier PR for Contact and ContactList refactoring.
The following classes were added:
The following classes were modified: