Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tagging feature for Contact #383

Merged
merged 5 commits into from
Oct 26, 2020

Conversation

jonasngs
Copy link
Collaborator

Fixes #382

This PR adds a tagging feature for Contact and modifies the related classes that are involved in tagging.

The following classes were modified:

  1. AddContactCommand: Change usage message
  2. AddContactParser: Modify parse method to parse tags
  3. EditContactCommand: Account for Tag when creating a new Contact
  4. EditContactParser: Modify parse method to parse tags
  5. EditContactDescriptor: Add methods to set and get Tag
  6. Contact: Create a field for Tag
  7. JsonAdaptedContact: Modify toModelType() method to convert a JsonAdaptedTag to a Tag object
  8. ContactCard: Modify constructor to display tags on GUI

@jonasngs jonasngs added type.Task Something that needs to be done, but not a story, bug, or an epic. priority.High Must do type.code A piece of code to be used labels Oct 25, 2020
@jonasngs jonasngs added this to the V1.3 milestone Oct 25, 2020
@jonasngs jonasngs self-assigned this Oct 25, 2020
@codecov-io
Copy link

Codecov Report

Merging #383 into master will decrease coverage by 0.25%.
The diff coverage is 7.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #383      +/-   ##
============================================
- Coverage     25.31%   25.06%   -0.26%     
  Complexity      339      339              
============================================
  Files           176      176              
  Lines          2864     2897      +33     
  Branches        332      338       +6     
============================================
+ Hits            725      726       +1     
- Misses         2074     2106      +32     
  Partials         65       65              
Impacted Files Coverage Δ Complexity Δ
...ommands/contactlistcommands/AddContactCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...mmands/contactlistcommands/EditContactCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...nds/contactlistcommands/EditContactDescriptor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ic/parser/contactlistparsers/AddContactParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/parser/contactlistparsers/EditContactParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/seedu/address/model/util/SampleDataUtil.java 21.42% <0.00%> (-16.08%) 1.00 <0.00> (ø)
...java/seedu/address/storage/JsonAdaptedContact.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/ContactCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...main/java/seedu/address/model/contact/Contact.java 64.86% <100.00%> (+0.97%) 15.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3f1616...96b0461. Read the comment docs.

Copy link
Collaborator

@michael-setia michael-setia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from possible incomplete input checking.

@jonasngs jonasngs merged commit 7eb2d23 into AY2021S1-CS2103T-F12-3:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.code A piece of code to be used type.Task Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement tagging feature for Contact
3 participants