Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Delete Assignment command #388

Merged
merged 7 commits into from
Oct 27, 2020

Conversation

murtubak
Copy link
Collaborator

fixes #387

@murtubak murtubak added priority.High Must do type.code A piece of code to be used labels Oct 26, 2020
@murtubak murtubak added this to the V1.3 milestone Oct 26, 2020
@murtubak murtubak self-assigned this Oct 26, 2020
@codecov-io
Copy link

Codecov Report

Merging #388 into master will decrease coverage by 0.71%.
The diff coverage is 6.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #388      +/-   ##
============================================
- Coverage     25.31%   24.59%   -0.72%     
- Complexity      339      341       +2     
============================================
  Files           176      181       +5     
  Lines          2864     2976     +112     
  Branches        332      349      +17     
============================================
+ Hits            725      732       +7     
- Misses         2074     2179     +105     
  Partials         65       65              
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/seedu/address/logic/LogicManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/main/java/seedu/address/logic/ParserManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../gradetrackercommands/DeleteAssignmentCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...seedu/address/logic/parser/GradeTrackerParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...a/seedu/address/logic/parser/ModuleListParser.java 56.00% <ø> (+4.14%) 10.00 <0.00> (ø)
...er/gradetrackerparsers/DeleteAssignmentParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/main/java/seedu/address/model/module/Module.java 20.65% <0.00%> (-0.23%) 6.00 <0.00> (ø)
...a/seedu/address/model/module/grade/Assignment.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../grade/exceptions/AssignmentNotFoundException.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...grade/exceptions/DuplicateAssignmentException.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3f1616...c3838e3. Read the comment docs.

Copy link
Collaborator

@jonasngs jonasngs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the code structure is good and javadocs are neat and concise. However, there is a potential bug in the DeleteAssignmentParser class that should be rectified.

@murtubak murtubak merged commit 097bcc0 into AY2021S1-CS2103T-F12-3:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.code A piece of code to be used
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement delete assignment feature
3 participants