Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FindTaskCommand for TodoList #419

Merged
merged 20 commits into from
Oct 29, 2020

Conversation

jonasngs
Copy link
Collaborator

@jonasngs jonasngs commented Oct 27, 2020

Fixes #175

This PR implements a command to find tasks using a set of search parameters.

The following classes were added:

  1. FindTaskParser: parse search parameters
  2. FindTaskCommand: execute command and update filteredTaskList according to the predicate
  3. FindTaskCriteria: encapsulates a list of predicate to test a contact with
  4. NameContainsKeywordsPredicate: predicate to test a task's name
  5. TaskContainsTagsPredicate: predicate to test a task's tags
  6. TaskMatchesDatePredicate: predicate to test a task's date
  7. TaskMatchesPriorityPredicate: predicate to test a task's predicate

@jonasngs jonasngs added type.Task Something that needs to be done, but not a story, bug, or an epic. priority.High Must do type.code A piece of code to be used labels Oct 27, 2020
@jonasngs jonasngs added this to the V1.3 milestone Oct 27, 2020
@jonasngs jonasngs self-assigned this Oct 27, 2020
@jonasngs jonasngs marked this pull request as ready for review October 29, 2020 10:56
Copy link
Collaborator

@davidcaiqifan davidcaiqifan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The code looks clean and well written with just a few inconsistencies.

src/main/java/seedu/address/model/contact/ContactName.java Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #419 into master will decrease coverage by 0.47%.
The diff coverage is 12.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #419      +/-   ##
============================================
- Coverage     18.72%   18.24%   -0.48%     
  Complexity      329      329              
============================================
  Files           205      210       +5     
  Lines          3776     3874      +98     
  Branches        458      477      +19     
============================================
  Hits            707      707              
- Misses         2991     3090      +99     
+ Partials         78       77       -1     
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/MainApp.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ommands/contactlistcommands/AddContactCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ands/contactlistcommands/DeleteContactCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...mmands/contactlistcommands/EditContactCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...nds/contactlistcommands/EditContactDescriptor.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...mmands/contactlistcommands/FindContactCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...mmands/contactlistcommands/ListContactCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...gic/commands/todolistcommands/FindTaskCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...a/seedu/address/logic/parser/ModuleListParser.java 48.27% <ø> (ø) 10.00 <0.00> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53a36dc...e77d18e. Read the comment docs.

@jonasngs jonasngs merged commit 33a0d4d into AY2021S1-CS2103T-F12-3:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.code A piece of code to be used type.Task Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TodoList: Implement find task feature
3 participants