-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement FindTaskCommand for TodoList #419
Implement FindTaskCommand for TodoList #419
Conversation
…matching the search inputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The code looks clean and well written with just a few inconsistencies.
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
============================================
- Coverage 18.72% 18.24% -0.48%
Complexity 329 329
============================================
Files 205 210 +5
Lines 3776 3874 +98
Branches 458 477 +19
============================================
Hits 707 707
- Misses 2991 3090 +99
+ Partials 78 77 -1
Continue to review full report at Codecov.
|
Fixes #175
This PR implements a command to find tasks using a set of search parameters.
The following classes were added:
FindTaskParser
: parse search parametersFindTaskCommand
: execute command and update filteredTaskList according to the predicateFindTaskCriteria
: encapsulates a list of predicate to test a contact withNameContainsKeywordsPredicate
: predicate to test a task's nameTaskContainsTagsPredicate
: predicate to test a task's tagsTaskMatchesDatePredicate
: predicate to test a task's dateTaskMatchesPriorityPredicate
: predicate to test a task's predicate