Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify FindContactCommand to allow finding contacts by tags #425

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Modify FindContactCommand to allow finding contacts by tags #425

merged 3 commits into from
Oct 28, 2020

Conversation

jonasngs
Copy link
Collaborator

Fixes #424

This PR modifies the existing FindContactCommand to implement finding contacts by tags.

The following classes were added:

  1. ContactContainsTagPredicate: Predicate to test if a contact contains the search tags
  2. FindContactCriteria: Class to encapsulate a list of predicates to test contacts with

The following classes were modified:

  1. FindContactCommand: Modify instance field to be a Predicate
  2. FindContactParser: Add a check for PREFIX_NAME

@jonasngs jonasngs added priority.High Must do severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. type.code A piece of code to be used labels Oct 28, 2020
@jonasngs jonasngs added this to the V1.3 milestone Oct 28, 2020
@jonasngs jonasngs self-assigned this Oct 28, 2020
michael-setia
michael-setia approved these changes Oct 28, 2020
View reviewed changes
Copy link
Collaborator

@michael-setia michael-setia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is clean and easy to understand. Overall, LGTM 😄

src/main/java/seedu/address/model/contact/FindContactCriteria.java Show resolved Hide resolved
@jonasngs jonasngs merged commit 3e98878 into AY2021S1-CS2103T-F12-3:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-setia michael-setia michael-setia approved these changes

Assignees

@jonasngs jonasngs

Labels
priority.High Must do severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. type.code A piece of code to be used
Projects
None yet
Milestone
V1.3
Development

Successfully merging this pull request may close these issues.

Modify FindContactCommand to enable searching by Tags
2 participants
@jonasngs @michael-setia