Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Fix blank module lesson argument when adding a zoom link to a module and missing whitespaces in message constraints #541

Merged
merged 3 commits into from
Oct 31, 2020
Merged

Bug: Fix blank module lesson argument when adding a zoom link to a module and missing whitespaces in message constraints #541

merged 3 commits into from
Oct 31, 2020

Conversation

jonasngs
Copy link
Collaborator

This PR:

Details of the bug can be found at: #540

The current hashmap for ZoomLink storage maps a String, containing the module lesson which the zoom link belongs to, to the ZoomLink object.

This makes it difficult to perform checks on the module lesson argument
provided by users to validate them.

Let's

  • Create a new ModuleLesson class to encapsulate details and methods
    relating to a module lesson
  • Modify the hashmap into a hashmap that maps a ModuleLesson object to
    the corresponding zoom link
  • Modify the AddZoomLinkCommand and AddZoomLinkParser accordingly

@jonasngs
The current hashmap for ZoomLink storage maps a String, containing the
28ed4ee 
module lesson which the zoom link belongs to, to the ZoomLink object.

This makes it difficult to perform checks on the module lesson argument
provided by users to validate them.

Let's
 * Create a new ModuleLesson class to encapsulate details and methods
   relating to a module lesson
 * Modify the hashmap into a hashmap that maps a ModuleLesson object to
   the corresponding zoom link
 * Modify the AddZoomLinkCommand and AddZoomLinkParser accordingly
@jonasngs
Modify ZoomLink message constraints
8b5f0ec
@jonasngs jonasngs added priority.Medium Nice to have severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. type.code A piece of code to be used labels Oct 31, 2020
@jonasngs jonasngs added this to the V1.4 milestone Oct 31, 2020
@jonasngs jonasngs self-assigned this Oct 31, 2020
michael-setia
michael-setia approved these changes Oct 31, 2020
View reviewed changes
Copy link
Collaborator

@michael-setia michael-setia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codes are neat and consistent. Overall, LGTM.

src/main/java/seedu/address/model/contact/ContactComparatorByName.java Show resolved Hide resolved
src/main/java/seedu/address/model/module/ModuleLesson.java Show resolved Hide resolved
src/main/java/seedu/address/model/module/ModuleLesson.java Show resolved Hide resolved
src/main/java/seedu/address/model/module/ModuleLesson.java Show resolved Hide resolved
@jonasngs jonasngs merged commit 3224f8c into AY2021S1-CS2103T-F12-3:master Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-setia michael-setia michael-setia approved these changes

Assignees

@jonasngs jonasngs

Labels
priority.Medium Nice to have severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. type.code A piece of code to be used
Projects
None yet
Milestone
V1.4
2 participants
@jonasngs @michael-setia