Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests : Update Junit tests for module list commands #549

Conversation

davidcaiqifan
Copy link
Collaborator

@davidcaiqifan davidcaiqifan commented Oct 31, 2020

Fixes #547
Creates or updates tests cases for
-EditModuleCommand
-ExitCommand
-HelpCommand
-ListModuleCommand

davidcaiqifan added 6 commits October 27, 2020 22:00
…into branch-v1.4-moduleListBaseCommandsTest-merge

# Conflicts:
#	src/main/java/seedu/address/model/module/Module.java
#	src/test/java/seedu/address/logic/commands/CommandTestUtil.java
#	src/test/java/seedu/address/logic/commands/modulelistcommands/ExitCommandTest.java
#	src/test/java/seedu/address/logic/commands/modulelistcommands/FindCommandTest.java
#	src/test/java/seedu/address/logic/commands/modulelistcommands/HelpCommandTest.java
#	src/test/java/seedu/address/testutil/EditModuleDescriptorBuilder.java
#	src/test/java/seedu/address/testutil/ModuleBuilder.java
#	src/test/java/seedu/address/testutil/TypicalModules.java
@davidcaiqifan davidcaiqifan self-assigned this Oct 31, 2020
@davidcaiqifan davidcaiqifan added priority.High Must do type.code A piece of code to be used type.Task Something that needs to be done, but not a story, bug, or an epic. labels Oct 31, 2020
davidcaiqifan and others added 5 commits October 31, 2020 22:57
…into branch-v1.4-moduleListBaseCommandsTest-merge

# Conflicts:
#	src/test/java/seedu/address/testutil/ModuleBuilder.java
#	src/test/java/seedu/address/testutil/TypicalModules.java
…//github.com/davidcaiqifan/tp into branch-v1.4-moduleListBaseCommandsTest-merge

# Conflicts:
#	src/test/java/seedu/address/testutil/ModuleBuilder.java
#	src/test/java/seedu/address/testutil/TypicalModules.java
…into branch-v1.4-moduleListBaseCommandsTest-merge

# Conflicts:
#	src/test/java/seedu/address/logic/commands/FindCommandTest.java
#	src/test/java/seedu/address/logic/commands/FindModuleCommandTest.java
#	src/test/java/seedu/address/logic/commands/modulelistcommands/FindCommandTest.java
Copy link
Collaborator

@MatthiasLHK MatthiasLHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidcaiqifan davidcaiqifan merged commit d98a627 into AY2021S1-CS2103T-F12-3:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.code A piece of code to be used type.Task Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests : Update Junit tests for module tracker commands
2 participants