Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DeleteZoomLinkCommand #553

Merged
merged 9 commits into from
Nov 1, 2020

Conversation

jonasngs
Copy link
Collaborator

Fixes #552

This PR implements a command to delete a zoom link from a module. Additionally, the user guide has been updated with the new feature.

The following classes were added:

  1. DeleteZoomLinkCommand: executes the deletion of a zoom link from the module
  2. DeleteZoomLinkParser: parsers the user input for a delete zoom link command

@jonasngs jonasngs added type.Task Something that needs to be done, but not a story, bug, or an epic. priority.Medium Nice to have type.code A piece of code to be used labels Oct 31, 2020
@jonasngs jonasngs added this to the V1.4 milestone Oct 31, 2020
@jonasngs jonasngs self-assigned this Oct 31, 2020
Copy link
Collaborator

@michael-setia michael-setia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some trivial questions in the comments. Overall, LGTM.

@codecov-io
Copy link

Codecov Report

Merging #553 into master will decrease coverage by 0.21%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #553      +/-   ##
============================================
- Coverage     18.87%   18.66%   -0.22%     
  Complexity      370      370              
============================================
  Files           227      229       +2     
  Lines          4398     4448      +50     
  Branches        524      534      +10     
============================================
  Hits            830      830              
- Misses         3493     3543      +50     
  Partials         75       75              
Impacted Files Coverage Δ Complexity Δ
...ands/contactlistcommands/DeleteContactCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...mmands/contactlistcommands/EditContactCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ommands/modulelistcommands/AddZoomLinkCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ands/modulelistcommands/DeleteZoomLinkCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...a/seedu/address/logic/parser/ModuleListParser.java 48.27% <0.00%> (+4.52%) 10.00 <0.00> (ø)
...ic/parser/contactlistparsers/AddContactParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ic/parser/modulelistparsers/AddZoomLinkParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...parser/modulelistparsers/DeleteZoomLinkParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...c/main/java/seedu/address/model/module/Module.java 15.65% <0.00%> (-0.14%) 4.00 <0.00> (ø)
.../java/seedu/address/model/module/ModuleLesson.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d33d80...70d66e4. Read the comment docs.

@jonasngs jonasngs merged commit 0e62717 into AY2021S1-CS2103T-F12-3:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium Nice to have type.code A piece of code to be used type.Task Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleList: Implement command to delete a zoom link from a module
3 participants