Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EditZoomLinkCommand #555

Merged
merged 6 commits into from
Nov 1, 2020

Conversation

jonasngs
Copy link
Collaborator

Fixes #554

This PR implements a command to edit a zoom link in a module. Additionally, the user guide has been updated with the edit zoom link feature.

The following classes were added:

  1. EditZoomLinkCommand: to execute the command to edit a zoom link
  2. EditZoomLinkParser: to parse the user input
  3. EditZoomDescriptor: class to encapsulate details of the edited zoom link and the module lesson that contains the zoom link to be edited

@jonasngs jonasngs added type.Task Something that needs to be done, but not a story, bug, or an epic. priority.Medium Nice to have type.code A piece of code to be used labels Oct 31, 2020
@jonasngs jonasngs added this to the V1.4 milestone Oct 31, 2020
@jonasngs jonasngs self-assigned this Oct 31, 2020
@codecov-io
Copy link

codecov-io commented Nov 1, 2020

Codecov Report

Merging #555 into master will decrease coverage by 0.51%.
The diff coverage is 8.46%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #555      +/-   ##
============================================
- Coverage     18.89%   18.37%   -0.52%     
- Complexity      370      375       +5     
============================================
  Files           227      233       +6     
  Lines          4392     4538     +146     
  Branches        524      548      +24     
============================================
+ Hits            830      834       +4     
- Misses         3487     3626     +139     
- Partials         75       78       +3     
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ands/contactlistcommands/DeleteContactCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...mmands/contactlistcommands/EditContactCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ommands/modulelistcommands/AddZoomLinkCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ands/modulelistcommands/DeleteZoomLinkCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...commands/modulelistcommands/EditModuleCommand.java 18.91% <0.00%> (ø) 3.00 <0.00> (ø)
...ommands/modulelistcommands/EditZoomDescriptor.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...mmands/modulelistcommands/EditZoomLinkCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...modulelistcommands/ViewArchivedModulesCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ic/parser/contactlistparsers/AddContactParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b620fe...e83b3f2. Read the comment docs.

Copy link
Collaborator

@michael-setia michael-setia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments but overall, LGTM.

docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Show resolved Hide resolved
@jonasngs jonasngs merged commit ccbd289 into AY2021S1-CS2103T-F12-3:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium Nice to have type.code A piece of code to be used type.Task Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleList: Implement a command to edit a zoom link in a module
3 participants