Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Junit tests for Command related classes #571

Merged
merged 19 commits into from
Nov 4, 2020
Merged

Implement Junit tests for Command related classes #571

merged 19 commits into from
Nov 4, 2020

Conversation

jonasngs
Copy link
Collaborator

@jonasngs jonasngs commented Nov 2, 2020

Fixes #570

This PR implements all the necessary Junit tests for the classes mentioned in issue #570

@jonasngs
Create ModelStub to implement Junit test for AddContactCommand class
3cd1ee5
@jonasngs
Implement methods in ModelStud for AddContactCommandTest class
26f6e1b
@jonasngs
Implement Junit tests for AddContactCommand class
d413c38
@jonasngs
Implement Junit tests for AddContactCommand class
6715828
@jonasngs
Implement Junit tests for DeleteContactCommand class
6c4b265
@jonasngs
Refactor EditPersonDescriptorBuilder into EditContactDescriptorBuilder
a2a2600
@jonasngs
Implement Junit tests for EditContactCommand class
67093cb
@jonasngs
Add Junit tests for EditContactCommand class
caa5cb5
@jonasngs
Implement Junit tests for EditContactDescriptor class
eb0d39b
@jonasngs
Implement Junit tests for FindContactCommand clas
b7e941d
@jonasngs
Implement Junit tests for ListContactCommand class
3180a76
@jonasngs
Implement Junit tests for FindTaskCommand class
92dfd8a
@jonasngs
Implement Junit tests for AddZoomLinkCommandTest
32e7406
@jonasngs
Implement Junit tests for DeleteZoomLinkCommand class
42f2b14
@jonasngs
Refactor EditZoomDescriptor and AddZoomDescriptor into one ZoomDescri…
853e42b 
…ptor class
@jonasngs
Implement Junit tests for EditZoomLinkCommand class
d3cc3d5
@jonasngs
Implement Junit tests for FindTaskCommand class
045b0a6
@jonasngs
Resolve checkstyle issues
a674ad6
@jonasngs jonasngs added type.Task Something that needs to be done, but not a story, bug, or an epic. priority.High Must do type.code A piece of code to be used labels Nov 2, 2020
@jonasngs jonasngs added this to the V1.4 milestone Nov 2, 2020
@jonasngs jonasngs self-assigned this Nov 2, 2020
MatthiasLHK
MatthiasLHK approved these changes Nov 4, 2020
View reviewed changes
Copy link
Collaborator

@MatthiasLHK MatthiasLHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few small issues about the commented parts.

src/main/java/seedu/address/logic/parser/contactlistparsers/ContactListParser.java Show resolved Hide resolved
src/test/java/seedu/address/logic/commands/todolistcommands/FindTaskCommandTest.java Show resolved Hide resolved
@jonasngs jonasngs merged commit b172736 into AY2021S1-CS2103T-F12-3:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthiasLHK MatthiasLHK MatthiasLHK approved these changes

Assignees

@jonasngs jonasngs

Labels
priority.High Must do type.code A piece of code to be used type.Task Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Milestone
V1.4
Development

Successfully merging this pull request may close these issues.

Implement Junit tests for commands
2 participants
@jonasngs @MatthiasLHK