Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Update contact card #582

Merged
merged 10 commits into from
Nov 4, 2020
Merged

Conversation

jonasngs
Copy link
Collaborator

@jonasngs jonasngs commented Nov 4, 2020

capture

This PR fixes #581.

The contact card is updated according to the image above.

The following features were implemented:

  • Differentiating tag colors according to application component
  • Refining GUI ListView
  • Refining cardpane of each component

@jonasngs jonasngs added type.Enhancement An enhancement to an existing story priority.Medium Nice to have type.code A piece of code to be used labels Nov 4, 2020
@jonasngs jonasngs self-assigned this Nov 4, 2020
@codecov-io
Copy link

Codecov Report

Merging #582 into master will increase coverage by 9.18%.
The diff coverage is 27.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #582      +/-   ##
============================================
+ Coverage     18.89%   28.08%   +9.18%     
- Complexity      370      627     +257     
============================================
  Files           227      241      +14     
  Lines          4392     4779     +387     
  Branches        524      582      +58     
============================================
+ Hits            830     1342     +512     
+ Misses         3487     3312     -175     
- Partials         75      125      +50     
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...eedu/address/logic/commands/ViewCommandResult.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ommands/contactlistcommands/AddContactCommand.java 94.11% <ø> (+94.11%) 8.00 <0.00> (+8.00)
...mmands/contactlistcommands/EditContactCommand.java 88.63% <ø> (+88.63%) 13.00 <0.00> (+13.00)
...mmands/modulelistcommands/CalculateCapCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...modulelistcommands/TargetCapCalculatorCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...modulelistcommands/ViewArchivedModulesCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...commands/modulelistcommands/ViewModuleCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ic/commands/schedulercommands/AddEventCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...commands/schedulercommands/DeleteEventCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 120 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25e9f46...b87bd9c. Read the comment docs.

Copy link
Collaborator

@davidcaiqifan davidcaiqifan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonasngs jonasngs merged commit f6bb596 into AY2021S1-CS2103T-F12-3:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium Nice to have type.code A piece of code to be used type.Enhancement An enhancement to an existing story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GUI: Refine contact list
3 participants