Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify EditContactCommand to allow deleting of telegram field #592

Merged

Conversation

jonasngs
Copy link
Collaborator

@jonasngs jonasngs commented Nov 4, 2020

This PR fixes #591

This PR address the issue of users being unable to delete a telegram field of a contact despite it being an optional field.

The following classes have been modified:

  1. EditContactDescriptor: Store an additional boolean field to indicate if users wish to delete the telegram field of a contact
  2. EditContactParser: handle the case when no argument for the te/ prefix was provided
  3. EditContactCommand: handle the execution of the correct command

Additionally, the user guide was updated to inform users of this feature.

@jonasngs jonasngs added priority.High Must do severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. type.code A piece of code to be used labels Nov 4, 2020
@jonasngs jonasngs added this to the V1.4 milestone Nov 4, 2020
@jonasngs jonasngs self-assigned this Nov 4, 2020
@codecov-io
Copy link

Codecov Report

Merging #592 into master will increase coverage by 13.79%.
The diff coverage is 28.31%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #592       +/-   ##
=============================================
+ Coverage     18.89%   32.68%   +13.79%     
- Complexity      370      756      +386     
=============================================
  Files           227      245       +18     
  Lines          4392     5020      +628     
  Branches        524      619       +95     
=============================================
+ Hits            830     1641      +811     
+ Misses         3487     3203      -284     
- Partials         75      176      +101     
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...rc/main/java/seedu/address/logic/LogicManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/main/java/seedu/address/logic/ParserManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...eedu/address/logic/commands/ViewCommandResult.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../commands/modulelistcommands/AddModuleCommand.java 31.81% <ø> (ø) 3.00 <0.00> (ø)
...mmands/modulelistcommands/CalculateCapCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...modulelistcommands/TargetCapCalculatorCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...modulelistcommands/ViewArchivedModulesCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ic/parser/contactlistparsers/AddContactParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/parser/contactlistparsers/ContactListParser.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
... and 157 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5080dc1...2715db5. Read the comment docs.

Copy link
Collaborator

@murtubak murtubak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jonasngs jonasngs merged commit 9b28b7d into AY2021S1-CS2103T-F12-3:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. type.code A piece of code to be used
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify EditContactCommand to enable deletion of telegram field
3 participants