Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test : JUnit testing for gradetracker #651

Merged
merged 20 commits into from
Nov 8, 2020

Conversation

murtubak
Copy link
Collaborator

@murtubak murtubak commented Nov 7, 2020

fixes #625
Added testing for gradetracker commands and parsers.
Also touched up on testing for exceptions in module and viewcommand result.

@murtubak murtubak marked this pull request as ready for review November 8, 2020 11:57
@codecov-io
Copy link

codecov-io commented Nov 8, 2020

Codecov Report

Merging #651 (93d2de1) into master (524ab2e) will increase coverage by 6.73%.
The diff coverage is 74.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #651      +/-   ##
============================================
+ Coverage     51.86%   58.59%   +6.73%     
- Complexity     1197     1339     +142     
============================================
  Files           245      247       +2     
  Lines          5158     5200      +42     
  Branches        670      686      +16     
============================================
+ Hits           2675     3047     +372     
+ Misses         2220     1878     -342     
- Partials        263      275      +12     
Impacted Files Coverage Δ Complexity Δ
...c/main/java/seedu/address/logic/ParserManager.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...gradetrackercommands/EditAssignmentDescriptor.java 75.00% <0.00%> (+75.00%) 11.00 <0.00> (+11.00)
.../seedu/address/logic/parser/ContactListParser.java 83.33% <ø> (ø) 15.00 <0.00> (?)
...seedu/address/model/module/grade/GradeTracker.java 70.58% <35.71%> (+6.39%) 24.00 <3.00> (+4.00)
...a/seedu/address/model/module/UniqueModuleList.java 73.17% <40.00%> (+9.75%) 16.00 <0.00> (+2.00)
...c/main/java/seedu/address/model/module/Module.java 58.77% <66.66%> (+7.46%) 25.00 <1.00> (+3.00)
...eedu/address/logic/commands/ViewCommandResult.java 88.88% <76.92%> (+88.88%) 13.00 <8.00> (+13.00)
.../gradetrackercommands/DeleteAssignmentCommand.java 96.87% <87.50%> (+96.87%) 12.00 <0.00> (+12.00)
...commands/gradetrackercommands/AddGradeCommand.java 100.00% <100.00%> (+100.00%) 11.00 <5.00> (+11.00)
...ds/gradetrackercommands/EditAssignmentCommand.java 80.00% <100.00%> (+80.00%) 16.00 <0.00> (+16.00)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33ac019...94527e2. Read the comment docs.

@murtubak murtubak self-assigned this Nov 8, 2020
@murtubak murtubak added this to the V1.4 milestone Nov 8, 2020
Copy link
Collaborator

@MatthiasLHK MatthiasLHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@murtubak murtubak merged commit 15461e0 into AY2021S1-CS2103T-F12-3:master Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test: Testing for gradetracker package
3 participants