Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Validation and Meaningful Exception Handling #104

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

kevnw
Copy link
Collaborator

@kevnw kevnw commented Oct 19, 2020

No description provided.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@80dc734). Click here to learn what that means.
The diff coverage is 2.63%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #104   +/-   ##
=========================================
  Coverage          ?   53.13%           
  Complexity        ?      595           
=========================================
  Files             ?      122           
  Lines             ?     2428           
  Branches          ?      296           
=========================================
  Hits              ?     1290           
  Misses            ?     1073           
  Partials          ?       65           
Impacted Files Coverage Δ Complexity Δ
...ddress/logic/commands/link/LinkMeetingCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../seedu/address/logic/parser/LinkCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...in/java/seedu/address/logic/parser/ParserUtil.java 72.91% <0.00%> (ø) 14.00 <0.00> (?)
src/main/java/seedu/address/model/task/Event.java 43.13% <0.00%> (ø) 20.00 <0.00> (?)
...n/java/seedu/address/storage/JsonAdaptedEvent.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...in/java/seedu/address/storage/JsonAdaptedTodo.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/main/java/seedu/address/model/task/Link.java 33.33% <50.00%> (ø) 2.00 <1.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80dc734...22d8e84. Read the comment docs.

@urieltan
Copy link
Collaborator

Looks good to merge

@urieltan urieltan merged commit c926aeb into AY2021S1-CS2103T-F12-4:master Oct 19, 2020
@kevnw kevnw added this to Done in Week 10 Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
3 participants