Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify delete todo/event to a more general delete task #129

Merged
merged 3 commits into from
Oct 26, 2020

Conversation

lerxcl
Copy link
Collaborator

@lerxcl lerxcl commented Oct 25, 2020

No description provided.

@lerxcl lerxcl added this to the v1.3 milestone Oct 25, 2020
@codecov-io
Copy link

Codecov Report

Merging #129 into master will decrease coverage by 0.05%.
The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #129      +/-   ##
============================================
- Coverage     51.21%   51.16%   -0.06%     
+ Complexity      652      647       -5     
============================================
  Files           133      132       -1     
  Lines          2675     2664      -11     
  Branches        375      373       -2     
============================================
- Hits           1370     1363       -7     
+ Misses         1206     1202       -4     
  Partials         99       99              
Impacted Files Coverage Δ Complexity Δ
...eedu/address/logic/parser/DeleteCommandParser.java 85.71% <87.50%> (+31.86%) 4.00 <0.00> (+2.00)
...dress/logic/commands/delete/DeleteTaskCommand.java 100.00% <100.00%> (ø) 7.00 <1.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ab6643...c52663d. Read the comment docs.

Copy link
Collaborator

@kevnw kevnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Well done. 👍

@kevnw kevnw merged commit 6253923 into AY2021S1-CS2103T-F12-4:master Oct 26, 2020
@kevnw kevnw added this to Done in Week 11 Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Add exception handling when delete command does not include "todo"/"event" term
3 participants