DG: Add implementation for "contactTaskTag", add more use stories, MSS, NFRs, Glossary, and Manual Testing #239
Conversation
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
=========================================
Coverage 67.18% 67.18%
Complexity 887 887
=========================================
Files 130 130
Lines 3020 3020
Branches 469 469
=========================================
Hits 2029 2029
Misses 783 783
Partials 208 208
Continue to review full report at Codecov.
|
| 4. A user with above average typing speed for regular English text (i.e. not code, not system admin commands) should be able to accomplish most of the tasks faster using commands than using the mouse. | ||
| 5. Commands should be intuitive so that users can quickly remember the commands. | ||
| 6. Should work without an Internet connection. | ||
| 7. Should not require more than 1 GB of storage space. |
There was a problem hiding this comment.
perhaps consider smaller storage space required since our jar file is only 13MB
| Expected: First contact is deleted from the list. Details of the deleted contact shown in the status message. Timestamp in the status bar is updated. | ||
|
|
||
| 1. Test case: `delete 0`<br> | ||
| 1. Test case: `delete contact 0`<br> | ||
| Expected: No person is deleted. Error details shown in the status message. Status bar remains the same. | ||
|
|
||
| 1. Other incorrect delete commands to try: `delete`, `delete x`, `...` (where x is larger than the list size)<br> |
There was a problem hiding this comment.
In the case of "delete x", it does not matter whether x is larger than the list size. Perhaps change the "delete x" to "delete contact x" or remove the phrase in bracket.
| !include style.puml | ||
| skinparam arrowThickness 1.1 | ||
| skinparam arrowColor MODEL_COLOR | ||
| skinparam classBackgroundColor MODEL_COLOR |
There was a problem hiding this comment.
Since command is part of the logic component, perhaps change the color to LOGIC_COLOR
| !include style.puml | ||
| skinparam arrowThickness 1.1 | ||
| skinparam arrowColor MODEL_COLOR | ||
| skinparam classBackgroundColor MODEL_COLOR |
There was a problem hiding this comment.
Since parser is part of the logic component, perhaps change the color to LOGIC_COLOR
| | `*` | user with many contacts in the Lifebook | sort persons by name | locate a person easily | | ||
| | `*` | student with weekly lectures and tutorials | add recurring tasks | save time by not adding the same task every week, which is time-consuming| | ||
| | `*` | student | have a common tag for my contact and task | easily search for the associated contacts with a task | |
There was a problem hiding this comment.
I feel like the phrase "easily search for the associated contacts with a task" is too technical and not user-oriented. Perhaps can change to something like "easily find a person I am working with in a project"
No description provided.