Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch fix website links #240

Merged

Conversation

urieltan
Copy link
Collaborator

@urieltan urieltan commented Nov 7, 2020

Fix some of the links in index.md and SettingUp.md

Copy link
Collaborator

@lerxcl lerxcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to rename your PPP, it is missing ".md".
I put created an issue for it!

@urieltan urieltan linked an issue Nov 7, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #240 (620dc9a) into master (3c3294d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #240   +/-   ##
=========================================
  Coverage     67.18%   67.18%           
  Complexity      887      887           
=========================================
  Files           130      130           
  Lines          3020     3020           
  Branches        469      469           
=========================================
  Hits           2029     2029           
  Misses          783      783           
  Partials        208      208           
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/model/task/Recurrence.java 51.85% <0.00%> (ø) 10.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c3294d...620dc9a. Read the comment docs.

Copy link
Collaborator

@lerxcl lerxcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, LGTM now! 👍

@lerxcl lerxcl merged commit 5a0af3a into AY2021S1-CS2103T-F12-4:master Nov 7, 2020
@urieltan urieltan linked an issue Nov 7, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index.md links are not pointing to userguide/developerguide webpage Include ".md" in PPP
3 participants