Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DG #242

Merged
Merged

Conversation

lerxcl
Copy link
Collaborator

@lerxcl lerxcl commented Nov 7, 2020

No description provided.

-Tweak NFR (100 mb instead of 1GB)
-Attempt to resize contactTaskTagSequenceDiagram
-Tweak user story of common tag
-Edit delete manual testing
@codecov-io
Copy link

Codecov Report

Merging #242 (8c36b80) into master (e626147) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #242   +/-   ##
=========================================
  Coverage     67.18%   67.18%           
  Complexity      887      887           
=========================================
  Files           130      130           
  Lines          3020     3020           
  Branches        469      469           
=========================================
  Hits           2029     2029           
  Misses          783      783           
  Partials        208      208           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e626147...8c36b80. Read the comment docs.

@lerxcl lerxcl added this to the v1.4 milestone Nov 7, 2020
Copy link
Collaborator

@urieltan urieltan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge

@urieltan urieltan merged commit 7e7fe73 into AY2021S1-CS2103T-F12-4:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants