Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Testing to Command Parser #253

Merged
merged 12 commits into from
Nov 8, 2020

Conversation

luciatirta
Copy link
Collaborator

No description provided.

@luciatirta luciatirta added this to the v1.4 milestone Nov 7, 2020
@codecov-io
Copy link

Codecov Report

Merging #253 (09ca6a5) into master (ede8664) will increase coverage by 2.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #253      +/-   ##
============================================
+ Coverage     68.96%   71.02%   +2.05%     
- Complexity      930      964      +34     
============================================
  Files           130      130              
  Lines          3042     3044       +2     
  Branches        475      475              
============================================
+ Hits           2098     2162      +64     
+ Misses          727      679      -48     
+ Partials        217      203      -14     
Impacted Files Coverage Δ Complexity Δ
...ava/seedu/address/logic/commands/ClearCommand.java 80.00% <0.00%> (-20.00%) 3.00 <1.00> (+1.00) ⬇️
...java/seedu/address/logic/commands/SortCommand.java 100.00% <ø> (+66.66%) 1.00 <0.00> (ø)
...ddress/logic/commands/list/ListContactCommand.java 80.00% <0.00%> (-20.00%) 3.00 <1.00> (+1.00) ⬇️
.../address/logic/commands/list/ListEventCommand.java 85.71% <0.00%> (-14.29%) 3.00 <1.00> (+1.00) ⬇️
...u/address/logic/commands/list/ListTaskCommand.java 83.33% <0.00%> (-16.67%) 3.00 <1.00> (+1.00) ⬇️
...u/address/logic/commands/list/ListTodoCommand.java 85.71% <0.00%> (-14.29%) 3.00 <1.00> (+1.00) ⬇️
.../seedu/address/logic/parser/AddressBookParser.java 100.00% <ø> (+30.43%) 18.00 <0.00> (+6.00)
.../seedu/address/logic/parser/ListCommandParser.java 100.00% <ø> (+58.33%) 6.00 <0.00> (+3.00)
...in/java/seedu/address/logic/parser/ParserUtil.java 98.33% <0.00%> (+3.33%) 20.00% <0.00%> (+1.00%)
...edu/address/logic/parser/ContactTaskTagParser.java 90.00% <0.00%> (+10.00%) 3.00% <0.00%> (ø%)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ede8664...09ca6a5. Read the comment docs.

@luciatirta luciatirta linked an issue Nov 7, 2020 that may be closed by this pull request
Copy link
Collaborator

@lerxcl lerxcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on improving code coverage!

@lerxcl lerxcl merged commit dd48453 into AY2021S1-CS2103T-F12-4:master Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Testing for ClearCommandParser and ListCommandParser
3 participants