add command to view details of an item #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 6, 2020
Closed
aqcd
reviewed
Oct 6, 2020
khenghun
reviewed
Oct 8, 2020
change gui name
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
============================================
- Coverage 63.21% 62.55% -0.66%
- Complexity 730 747 +17
============================================
Files 124 128 +4
Lines 2539 2604 +65
Branches 269 278 +9
============================================
+ Hits 1605 1629 +24
- Misses 847 882 +35
- Partials 87 93 +6
Continue to review full report at Codecov.
|
Rahul0506
reviewed
Oct 8, 2020
Comment on lines
+52
to
+60
| public static boolean containsMultipleWordsIgnoreCase(String sentence, String words) { | ||
| requireNonNull(sentence); | ||
| requireNonNull(words); | ||
|
|
||
| String preppedWord = words.trim(); | ||
| checkArgument(!preppedWord.isEmpty(), "Word parameter cannot be empty"); | ||
|
|
||
| return sentence.equalsIgnoreCase(preppedWord); | ||
| } |
There was a problem hiding this comment.
Would be better to name it as "exactlyMultipleWordsIgnoreCase"? "contains" is a little misleading.
Rahul0506
reviewed
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also changed the UG link