Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View recipe #47

Merged
merged 16 commits into from
Oct 12, 2020
Merged

View recipe #47

merged 16 commits into from
Oct 12, 2020

Conversation

khenghun
Copy link

Enable viewing of all items, all recipes, or a specific item

@khenghun khenghun added the feature.Recipe Issues related to recipes. label Oct 10, 2020
@khenghun khenghun added this to the v1.2 milestone Oct 10, 2020
@codecov-io
Copy link

codecov-io commented Oct 10, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@7e4760e). Click here to learn what that means.
The diff coverage is 36.56%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #47   +/-   ##
=========================================
  Coverage          ?   63.41%           
  Complexity        ?      789           
=========================================
  Files             ?      136           
  Lines             ?     2687           
  Branches          ?      286           
=========================================
  Hits              ?     1704           
  Misses            ?      888           
  Partials          ?       95           
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/seedu/address/logic/LogicManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...eedu/address/logic/commands/DeleteItemCommand.java 65.38% <0.00%> (ø) 9.00 <0.00> (?)
...eedu/address/logic/parser/InventoryListParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...va/seedu/address/logic/parser/InventoryParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 4.00 <0.00> (?)
...rc/main/java/seedu/address/model/ModelManager.java 78.57% <ø> (ø) 52.00 <0.00> (?)
...in/java/seedu/address/model/item/DetailedItem.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ava/seedu/address/model/recipe/IngredientList.java 66.66% <ø> (ø) 14.00 <0.00> (?)
...c/main/java/seedu/address/model/recipe/Recipe.java 85.71% <0.00%> (ø) 24.00 <0.00> (?)
...c/main/java/seedu/address/ui/DetailedItemCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4760e...68f4ef7. Read the comment docs.

Copy link

@blackonyyx blackonyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some Namespace changes should be made especially item extends Inventory

Copy link

@Rahul0506 Rahul0506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khenghun khenghun merged commit bd6bc8a into AY2021S1-CS2103T-F13-1:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature.Recipe Issues related to recipes.
Projects
None yet
5 participants