Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update delr and cleaning #66

Merged

Conversation

justacasul
Copy link

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #66 into master will decrease coverage by 0.01%.
The diff coverage is 68.96%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #66      +/-   ##
============================================
- Coverage     67.62%   67.60%   -0.02%     
+ Complexity      657      645      -12     
============================================
  Files           110      110              
  Lines          2091     2062      -29     
  Branches        226      220       -6     
============================================
- Hits           1414     1394      -20     
+ Misses          593      589       -4     
+ Partials         84       79       -5     
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/seedu/address/logic/LogicManager.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...in/java/seedu/address/model/item/DetailedItem.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/seedu/address/model/item/UniqueItemList.java 92.30% <ø> (-0.55%) 27.00 <0.00> (-2.00)
...a/seedu/address/model/recipe/UniqueRecipeList.java 90.24% <ø> (+2.74%) 21.00 <0.00> (-1.00) ⬆️
.../java/seedu/address/model/util/SampleDataUtil.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/model/item/Item.java 84.00% <40.00%> (+0.07%) 25.00 <0.00> (-5.00) ⬆️
...c/main/java/seedu/address/model/recipe/Recipe.java 84.61% <71.42%> (-1.44%) 22.00 <2.00> (-3.00)
...eedu/address/logic/commands/DeleteItemCommand.java 84.00% <100.00%> (+7.07%) 10.00 <4.00> (ø)
...du/address/logic/commands/DeleteRecipeCommand.java 100.00% <100.00%> (ø) 13.00 <2.00> (-1.00)
.../seedu/address/logic/commands/EditItemCommand.java 83.82% <100.00%> (ø) 14.00 <0.00> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1a14ea...f77de80. Read the comment docs.

@justacasul justacasul self-assigned this Oct 17, 2020
Copy link

@aqcd aqcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Rahul0506 Rahul0506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the delete method mentioned

src/main/java/seedu/address/model/recipe/Recipe.java Outdated Show resolved Hide resolved
@justacasul justacasul merged commit 152309e into AY2021S1-CS2103T-F13-1:master Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants