Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searchbytag #85

Merged
merged 15 commits into from
Oct 28, 2020
Merged

Conversation

blackonyyx
Copy link

@blackonyyx blackonyyx commented Oct 25, 2020

Resolves #35
Resolves #46
Resolves #93

@blackonyyx blackonyyx marked this pull request as ready for review October 26, 2020 15:02
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
@blackonyyx blackonyyx requested a review from aqcd October 27, 2020 15:02
@blackonyyx blackonyyx added this to the v1.3b milestone Oct 28, 2020
@blackonyyx blackonyyx added type.Enhancement Enhancements to existing user story. type.Story User story. labels Oct 28, 2020
@blackonyyx blackonyyx self-assigned this Oct 28, 2020
and additions from merged PR
@codecov-io
Copy link

Codecov Report

Merging #85 into master will increase coverage by 0.56%.
The diff coverage is 88.76%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #85      +/-   ##
============================================
+ Coverage     73.68%   74.25%   +0.56%     
- Complexity      793      828      +35     
============================================
  Files           118      123       +5     
  Lines          2356     2443      +87     
  Branches        260      275      +15     
============================================
+ Hits           1736     1814      +78     
- Misses          527      530       +3     
- Partials         93       99       +6     
Impacted Files Coverage Δ Complexity Δ
.../seedu/address/logic/commands/FindItemCommand.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
...s/logic/parser/AddQuantityToItemCommandParser.java 81.81% <ø> (ø) 3.00 <0.00> (ø)
...va/seedu/address/logic/parser/InventoryParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...main/java/seedu/address/ui/InventoryUiManager.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../address/logic/parser/AddItemTagCommandParser.java 81.81% <81.81%> (ø) 3.00 <3.00> (?)
...eedu/address/logic/commands/AddItemTagCommand.java 83.78% <83.78%> (ø) 10.00 <10.00> (?)
...seedu/address/logic/commands/FindByTagCommand.java 100.00% <100.00%> (ø) 8.00 <8.00> (?)
...u/address/logic/parser/FindByTagCommandParser.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
...du/address/logic/parser/FindItemCommandParser.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...ava/seedu/address/logic/parser/ItemParserUtil.java 96.42% <100.00%> (+0.13%) 12.00 <0.00> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8897903...d0f19ff. Read the comment docs.

@blackonyyx blackonyyx merged commit 4fc2cb7 into AY2021S1-CS2103T-F13-1:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Enhancement Enhancements to existing user story. type.Story User story.
Projects
None yet
5 participants