forked from nus-cs2103-AY2021S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Searchbytag #85
Merged
blackonyyx
merged 15 commits into
AY2021S1-CS2103T-F13-1:master
from
blackonyyx:searchbytag
Oct 28, 2020
Merged
Searchbytag #85
blackonyyx
merged 15 commits into
AY2021S1-CS2103T-F13-1:master
from
blackonyyx:searchbytag
Oct 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
find item by tag command is added
update local
to something more suitable
update local
aqcd
requested changes
Oct 26, 2020
src/test/java/seedu/address/logic/commands/AddItemTagCommandTest.java
Outdated
Show resolved
Hide resolved
src/test/java/seedu/address/logic/parser/AddItemTagCommandParserTest.java
Outdated
Show resolved
Hide resolved
src/test/java/seedu/address/logic/parser/AddItemTagCommandParserTest.java
Outdated
Show resolved
Hide resolved
src/test/java/seedu/address/logic/parser/FindByTagCommandParserTest.java
Show resolved
Hide resolved
Resolve issue with spacing in comma seperation tags.
aqcd
approved these changes
Oct 28, 2020
Rahul0506
reviewed
Oct 28, 2020
src/main/java/seedu/address/logic/commands/AddItemTagCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/logic/commands/AddItemTagCommand.java
Outdated
Show resolved
Hide resolved
blackonyyx
added
type.Enhancement
Enhancements to existing user story.
type.Story
User story.
labels
Oct 28, 2020
and additions from merged PR
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
============================================
+ Coverage 73.68% 74.25% +0.56%
- Complexity 793 828 +35
============================================
Files 118 123 +5
Lines 2356 2443 +87
Branches 260 275 +15
============================================
+ Hits 1736 1814 +78
- Misses 527 530 +3
- Partials 93 99 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #35
Resolves #46
Resolves #93