Integrate Notes feature with Ui #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TanLeYang
requested review from
pangpuncake,
mgiang2015,
angrybunny123 and
pennhanlee
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
============================================
- Coverage 74.10% 72.80% -1.31%
Complexity 669 669
============================================
Files 105 106 +1
Lines 2078 2114 +36
Branches 238 242 +4
============================================
- Hits 1540 1539 -1
- Misses 455 492 +37
Partials 83 83
Continue to review full report at Codecov.
|
This reverts commit c25b853. Method was necessary, mistakenly deleted
docs/DeveloperGuide.md
Outdated
| @@ -184,7 +185,7 @@ detailed view: | |||
|
|
|||
| * **Alternative 1 (current choice):** Use JavaFX ListView | |||
| * Pros: Easy to keep UI up to sync with model by overriding ListCell's updateItem method | |||
| * Cons: Can allow for displaying of multiple DetailedBookCards even though the detailed view is only meant to show | |||
| * Cons: Technically allows for displaying of multiple books even though the detailed view is only meant to show | |||
There was a problem hiding this comment.
I think saying 'Technically Allows' is a bit weird because it implies that it is a bug. Maybe we can add a statement to explain why the bug wouldn't occur?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #112
Integrate the notes feature into the Ui.
For books that have notes added, the Ui will show the title of the notes in the summarized view.
When viewing a book in the detailed view, the Ui will display the title and text of all the notes added to the book.
The notes are displayed in the detailed view using JavaFx's
ListViewincluded inDetailedBookListPanel