Fix bookmark integer overflow and Notes UI bug #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TanLeYang
requested review from
mgiang2015,
pangpuncake,
angrybunny123 and
pennhanlee
TanLeYang
changed the title
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
============================================
+ Coverage 71.32% 71.69% +0.37%
Complexity 745 745
============================================
Files 127 127
Lines 2420 2406 -14
Branches 271 269 -2
============================================
- Hits 1726 1725 -1
+ Misses 596 582 -14
- Partials 98 99 +1
Continue to review full report at Codecov.
|
| @@ -74,7 +75,7 @@ public static boolean isNonZeroUnsignedInteger(String s) { | |||
| */ | |||
| public static String trimLeadingZeroes(String s) { | |||
| requireNonNull(s); | |||
| int value = Integer.parseInt(s); | |||
| BigInteger value = new BigInteger(s); | |||
There was a problem hiding this comment.
I'm not sure if this needs to be here as you mentioned in the PR that you were using the regex solution instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #163
Added length limit to the regex of the bookmark field to prevent integer overflow.
Wanted to use BigInteger but it would require changing the whole project to use BigInteger so just went with the regex solution.
Closes #162
Allow text to wrap around instead of being truncated into ellipses when the text is too long to be displayed in a single line.
Here's how it looks now with the maximum number of allowable characters for note and note title:
DG changes
Modified the DG for the undo/redo feature to include the new changes I added last week