Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goal Feature: Update DG #167

Merged
merged 6 commits into from
Nov 5, 2020
Merged

Goal Feature: Update DG #167

merged 6 commits into from
Nov 5, 2020

Conversation

mgiang2015
Copy link
Collaborator

Update DG for Goal Feature, including diagrams

pennhanlee
pennhanlee reviewed Nov 3, 2020
View reviewed changes
Copy link
Collaborator

@pennhanlee pennhanlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For GoalClassDiagram.puml, will it be better to follow the hierarchal order and put the interface ontop of the implemented class?

TanLeYang
TanLeYang reviewed Nov 3, 2020
View reviewed changes
Copy link
Collaborator

@TanLeYang TanLeYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@angrybunny123
Copy link
Collaborator

LGTM!

@mgiang2015
Copy link
Collaborator Author

For GoalClassDiagram.puml, will it be better to follow the hierarchal order and put the interface ontop of the implemented class?

Updated diagram to follow hierarchal order

@pennhanlee pennhanlee merged commit 9130d4c into AY2021S1-CS2103T-F13-2:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TanLeYang TanLeYang TanLeYang left review comments

@pennhanlee pennhanlee pennhanlee left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mgiang2015 @angrybunny123 @TanLeYang @pennhanlee