Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DG user stories, use cases and manual testing sections and some test changes #170

Merged
merged 8 commits into from
Nov 5, 2020

Conversation

TanLeYang
Copy link
Collaborator

  • Updated the above mentioned sections of the DG
  • Some refinements to the tests for Name, Genre and Tag
  • Add tests for ViewTypeManager

@codecov-io
Copy link

codecov-io commented Nov 3, 2020

Codecov Report

Merging #170 into master will decrease coverage by 0.16%.
The diff coverage is 8.69%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #170      +/-   ##
============================================
- Coverage     71.67%   71.51%   -0.17%     
- Complexity      746      749       +3     
============================================
  Files           127      127              
  Lines          2415     2426      +11     
  Branches        270      267       -3     
============================================
+ Hits           1731     1735       +4     
- Misses          584      593       +9     
+ Partials        100       98       -2     
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/bookmark/model/book/Genre.java 83.33% <ø> (ø) 7.00 <0.00> (ø)
src/main/java/seedu/bookmark/ui/BookCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/bookmark/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ain/java/seedu/bookmark/logic/ViewTypeManager.java 100.00% <100.00%> (+21.42%) 8.00 <1.00> (+3.00)
.../main/java/seedu/bookmark/model/history/State.java 80.76% <100.00%> (ø) 12.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58da45e...25891a6. Read the comment docs.

Copy link
Collaborator

@pennhanlee pennhanlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides a small typo in DG


2. Adding a book while only some books are being shown.

1. Test case: `add n/Test book g/TEst genre tp/1000 b/50`<br>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo with Test genre

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right nice catch!

Copy link
Collaborator

@pangpuncake pangpuncake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@angrybunny123 angrybunny123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@mgiang2015 mgiang2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TanLeYang TanLeYang merged commit e942aa5 into AY2021S1-CS2103T-F13-2:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants