-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DG user stories, use cases and manual testing sections and some test changes #170
Conversation
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
============================================
- Coverage 71.67% 71.51% -0.17%
- Complexity 746 749 +3
============================================
Files 127 127
Lines 2415 2426 +11
Branches 270 267 -3
============================================
+ Hits 1731 1735 +4
- Misses 584 593 +9
+ Partials 100 98 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides a small typo in DG
docs/DeveloperGuide.md
Outdated
|
||
2. Adding a book while only some books are being shown. | ||
|
||
1. Test case: `add n/Test book g/TEst genre tp/1000 b/50`<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo with Test genre
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right nice catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Name
,Genre
andTag
ViewTypeManager