Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor addcommand #84

Merged

Conversation

pennhanlee
Copy link
Collaborator

Closes #44

The Add book command is refactored to now accept books instead of person.
eg. add n/Naruto g/Manga total/500 bookmark/1 t/Anime t/Japanese

Code

  • Refactored Add command to take in Total Pages and Book Mark|
  • Refactored Error Messages
  • Bookmark is optional and will be defaulted to 0 if not indicated

Test

  • Updated tests under Add Command and its related unit tests
  • Enabled all previously disabled tests related to Add Command
  • Created several new constants for Testing purposes

@pennhanlee pennhanlee added this to the v1.2 milestone Oct 5, 2020
@pennhanlee pennhanlee self-assigned this Oct 5, 2020
@pennhanlee pennhanlee added the type.Story A user story label Oct 5, 2020
Copy link
Collaborator

@pangpuncake pangpuncake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few fixes, other than that, LGTM!

src/main/java/seedu/bookmark/logic/parser/CliSyntax.java Outdated Show resolved Hide resolved
src/main/java/seedu/bookmark/logic/parser/ParserUtil.java Outdated Show resolved Hide resolved
Copy link
Collaborator

@TanLeYang TanLeYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@pangpuncake pangpuncake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pangpuncake pangpuncake merged commit e26a0fb into AY2021S1-CS2103T-F13-2:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Story A user story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a reader, I want to add a new book for it to be tracked
3 participants