Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor edit command #85

Merged
merged 11 commits into from
Oct 6, 2020
Merged

Refactor edit command #85

merged 11 commits into from
Oct 6, 2020

Conversation

pangpuncake
Copy link
Collaborator

@pangpuncake pangpuncake commented Oct 6, 2020 •
edited

Closes #45
Closes #48

pennhanlee
pennhanlee reviewed Oct 6, 2020
View reviewed changes
Copy link
Collaborator

@pennhanlee pennhanlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from some minor details which i have commented!

src/test/java/seedu/bookmark/logic/commands/EditBookDescriptorTest.java Show resolved Hide resolved
src/test/java/seedu/bookmark/testutil/BookBuilder.java Outdated Show resolved Hide resolved
@TanLeYang TanLeYang mentioned this pull request Oct 6, 2020
Merged
angrybunny123
angrybunny123 reviewed Oct 6, 2020
View reviewed changes
Copy link
Collaborator

@angrybunny123 angrybunny123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once you edit the javadocs and test names we can merge!

src/test/java/seedu/bookmark/logic/commands/EditCommandTest.java Outdated Show resolved Hide resolved
src/test/java/seedu/bookmark/logic/commands/EditCommandTest.java Outdated Show resolved Hide resolved
pennhanlee
pennhanlee reviewed Oct 6, 2020
View reviewed changes
Copy link
Collaborator

@pennhanlee pennhanlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angrybunny123
Copy link
Collaborator

Looks good to me, Wai Kye!

TanLeYang
TanLeYang approved these changes Oct 6, 2020
View reviewed changes
Copy link
Collaborator

@TanLeYang TanLeYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 😄

@TanLeYang TanLeYang merged commit 3247778 into AY2021S1-CS2103T-F13-2:master Oct 6, 2020
@pangpuncake pangpuncake deleted the branch-refactor-edit-command branch October 9, 2020 07:23
@pangpuncake pangpuncake mentioned this pull request Oct 9, 2020
Closed
@pangpuncake pangpuncake modified the milestones: v1.2b, v1.2 Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angrybunny123 angrybunny123 angrybunny123 left review comments

@pennhanlee pennhanlee pennhanlee left review comments

@TanLeYang TanLeYang TanLeYang approved these changes

@mgiang2015 mgiang2015 Awaiting requested review from mgiang2015

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2
4 participants
@pangpuncake @angrybunny123 @TanLeYang @pennhanlee