Add view command #90
Merged
Add view command #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… works as expected
mgiang2015
requested review from
TanLeYang,
angrybunny123,
pangpuncake and
pennhanlee
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
=========================================
Coverage ? 69.62%
Complexity ? 405
=========================================
Files ? 73
Lines ? 1297
Branches ? 132
=========================================
Hits ? 903
Misses ? 354
Partials ? 40
Continue to review full report at Codecov.
|
TanLeYang
reviewed
Oct 8, 2020
| @Test | ||
| public void equals() { | ||
| ViewCommand deleteFirstCommand = new ViewCommand(INDEX_FIRST_BOOK); | ||
| ViewCommand deleteSecondCommand = new ViewCommand(INDEX_SECOND_BOOK); |
There was a problem hiding this comment.
I think there's a typo here, should be viewFirstCommand and viewSecondCommand right?
|
|
||
| import java.util.function.Predicate; | ||
|
|
||
| public class IsSpecifiedBookPredicate implements Predicate<Book> { |
There was a problem hiding this comment.
Perhaps you could include a super simple javadoc for this class?
pennhanlee
reviewed
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to view only the book specified by index. No additional information is shown compared to list command for now, will see how that can be improved
closes #49