Update product website, UG and minor code refactoring #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TanLeYang
requested review from
mgiang2015,
pangpuncake,
angrybunny123 and
pennhanlee
TanLeYang
changed the title
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
============================================
+ Coverage 67.40% 67.49% +0.09%
- Complexity 448 451 +3
============================================
Files 80 80
Lines 1448 1449 +1
Branches 152 152
============================================
+ Hits 976 978 +2
+ Misses 425 423 -2
- Partials 47 48 +1
Continue to review full report at Codecov.
|
pennhanlee
reviewed
Oct 14, 2020
Comment on lines
34
to
36
| int pagesRead = book.getPagesRead(); | ||
| int totalPages = book.getTotalPagesNumber(); | ||
| return (int) (((float) pagesRead / totalPages) * 100); |
There was a problem hiding this comment.
Maybe it will be better to immediately cast the float type upon instantiation instead of typecasting at Ln36?
Else, LGTM!
There was a problem hiding this comment.
Good suggestion! I've made the necessary changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor additions and fixes for #92
DetailedBookCard