Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more details for note command in DG #125

Merged

Conversation

wang-jun-hao
Copy link

No description provided.

@wang-jun-hao wang-jun-hao added the type.Documentation Improvements or additions to documentation label Oct 21, 2020
@codecov-io
Copy link

codecov-io commented Oct 21, 2020

Codecov Report

Merging #125 into master will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #125      +/-   ##
============================================
+ Coverage     68.07%   68.11%   +0.03%     
  Complexity      595      595              
============================================
  Files            94       94              
  Lines          2055     2054       -1     
  Branches        234      234              
============================================
  Hits           1399     1399              
+ Misses          579      578       -1     
  Partials         77       77              
Impacted Files Coverage Δ Complexity Δ
...medibook/ui/patientprofile/MedicalDetailsCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../medibook/ui/patientprofile/MedicalDetailsRow.java 0.00% <ø> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e461a91...a74ae52. Read the comment docs.

Copy link

@foojingyi foojingyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, otherwise LGTM!

Note: Every `patient` in the `model` has a `MedicalNoteList` that is initialised as an empty list at
program start-up to optimise start-up time.

Step 2. The user then `access` the patient using the index of the patient in the filtered list.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds grammatically incorrect to say "the user then access" even though it is clear in the markup that this is a command. Is there a way to rephrase this sentence?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Change grammar on line 157
Copy link

@foojingyi foojingyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@foojingyi foojingyi merged commit fd433cc into AY2021S1-CS2103T-F13-3:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants