Add support for IC field #13

PrestonTYR · 2020-09-26T11:23:43Z

Implement IC class
Update AddCommand, EditCommand and Person to include IC
Closes #6

src/main/java/seedu/address/logic/commands/AddCommand.java

src/main/java/seedu/address/model/person/Ic.java

src/test/java/seedu/address/logic/parser/AddCommandParserTest.java

src/test/java/seedu/address/logic/parser/EditCommandParserTest.java

src/test/java/seedu/address/storage/JsonAdaptedPersonTest.java

…erson

…, T, F or G

Wong-ZZ

lgtm

Add support for IC field

876afbc

PrestonTYR added this to the v1.1 milestone Sep 26, 2020

PrestonTYR added 5 commits September 26, 2020 21:43

Fix bug in EditCommand that didn't allow user to edit Persons

84f737c

Update test cases to include IC

b2d9ccd

Update AddCommand to display proper message usage string

4ed0961

Update tests to test for IC

966efb5

Update Ic regex and add test cases

e192377

Wong-ZZ reviewed Sep 28, 2020

View reviewed changes

PrestonTYR and others added 7 commits September 28, 2020 14:51

Update code to only use IC when checking if 2 Person's are the same P…

80030cd

…erson

Update test cases to check for invalid or multiple inputs of IC

2d0d21b

Update regex for IC so last character can only be 1 letter

e7f4fa6

Update regex for IC so that first character can only be 1 letter of S…

c4f0e21

…, T, F or G

Add more test cases for invalid ICs

be2a78d

Merge branch 'master' into branch-ic-field

a952a1a

Fix errors after resolving merge conflicts

83aea1c

Wong-ZZ approved these changes Sep 30, 2020

View reviewed changes

Wong-ZZ merged commit 1a03d83 into AY2021S1-CS2103T-F13-3:master Sep 30, 2020

PrestonTYR added priority.High type.Enhancement labels Sep 30, 2020

Provide feedback