Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch update ug #173

Merged
merged 3 commits into from
Oct 29, 2020

Conversation

foojingyi
Copy link

@foojingyi foojingyi commented Oct 29, 2020

Update UG with Allergy, Condition and Treatment fields

FooJingYi added 3 commits October 30, 2020 03:23
* 'master' of https://github.com/AY2021S1-CS2103T-F13-3/tp:
  Update version of app for v1.3 jar release
  Add additional details to userguide
  Update userguide
* master: (173 commits)
  Update version of app for v1.3 jar release
  Add additional details to userguide
  Update userguide
  Update UserGuide.md
  Change XYChart.Data to XYChart.Data<>
  Change date format in charts to dd-mm-yy
  Update UserGuide.md
  Make charts available even when height/weight is present without the other
  Fix scroll bug for charts
  Update UI
  Update add command constraints message
  Update PatientChartCard.java
  Fix bug for loading a patient without any past records
  Update createAccount so that admin cannot be used as username
  Fix bug where user can still invoke access command from a patient profile page
  Readjust graph locations
  Update UserGuide.md
  Update Mcr constructor to convert mcr to all caps
  Update login admin account details in UG
  Remove print line used for testing
  ...
@codecov-io
Copy link

Codecov Report

Merging #173 into master will decrease coverage by 2.06%.
The diff coverage is 59.69%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #173      +/-   ##
============================================
- Coverage     68.11%   66.05%   -2.07%     
- Complexity      595      848     +253     
============================================
  Files            94      120      +26     
  Lines          2054     3031     +977     
  Branches        234      356     +122     
============================================
+ Hits           1399     2002     +603     
- Misses          578      894     +316     
- Partials         77      135      +58     
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/medibook/MainApp.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ain/java/seedu/medibook/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...java/seedu/medibook/logic/commands/AddCommand.java 85.71% <0.00%> (-14.29%) 8.00 <0.00> (ø)
...c/main/java/seedu/medibook/model/AdminAccount.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/main/java/seedu/medibook/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...n/java/seedu/medibook/model/commonfields/Name.java 80.00% <ø> (ø) 6.00 <0.00> (?)
...in/java/seedu/medibook/storage/JsonAdaptedTag.java 70.00% <ø> (-30.00%) 3.00 <0.00> (-2.00)
...in/java/seedu/medibook/ui/CreateAccountWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/main/java/seedu/medibook/ui/LoginWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/main/java/seedu/medibook/ui/UiManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 93 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 295418f...52d134d. Read the comment docs.

Copy link

@PrestonTYR PrestonTYR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PrestonTYR PrestonTYR merged commit 4c1cbe9 into AY2021S1-CS2103T-F13-3:master Oct 29, 2020
@PrestonTYR PrestonTYR added the type.Documentation Improvements or additions to documentation label Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants