Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MedicalNote class and tests #56

Conversation

foojingyi
Copy link

Resolves #54

FooJingYi added 3 commits October 2, 2020 16:19
* 'master' of https://github.com/AY2021S1-CS2103T-F13-3/tp: (29 commits)
  Remove trailing whitespace on line 151
  Re-arranged order of fields in method
  Update comments
  Fix bug in parse_invalidValueFollowedByValidValue_success()
  Add javadoc for build() method
  Add whitespace on line 140 before '+'
  Update AddCommandParser.java
  Line wrap AddCommandParser.java
  Update JsonAdaptedPerson.java
  Update AddCommandParserTest.java
  Update docs/_config.yml file to replace AB-3 with MediBook
  Fixed bug in sample data
  Add testing for persons with Date Of Birth Field
  Add support for Date Of Birth field
  Update UniquePersonListTest.java to include different blood type field for person with same identity
  Minor fix in comments
  Update javadoc in ParserUtil.java for proper capitalisation
  Update UniquePersonListTest to test for the same identity with all non-ic fields being different
  Add new blood type field
  Add new blood type field
  ...
Copy link

@wang-jun-hao wang-jun-hao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost good to merge. minor changes requested with regards to access modifiers and javadoc comment.

@PrestonTYR PrestonTYR added this to the v1.2 milestone Oct 7, 2020
Copy link

@wang-jun-hao wang-jun-hao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wang-jun-hao wang-jun-hao merged commit 567af61 into AY2021S1-CS2103T-F13-3:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create MedicalNote Class
3 participants