forked from nus-cs2103-AY2021S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update certain fields to become optional #58
Merged
Wong-ZZ
merged 9 commits into
AY2021S1-CS2103T-F13-3:master
from
PrestonTYR:branch-optional-fields
Oct 8, 2020
Merged
Update certain fields to become optional #58
Wong-ZZ
merged 9 commits into
AY2021S1-CS2103T-F13-3:master
from
PrestonTYR:branch-optional-fields
Oct 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrestonTYR
changed the title
Branch optional fields
Update certain fields to become optional
Oct 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
============================================
- Coverage 76.09% 72.59% -3.51%
- Complexity 492 498 +6
============================================
Files 77 78 +1
Lines 1523 1613 +90
Branches 171 188 +17
============================================
+ Hits 1159 1171 +12
- Misses 321 381 +60
- Partials 43 61 +18
Continue to review full report at Codecov.
|
Wong-ZZ
reviewed
Oct 8, 2020
src/main/java/seedu/address/logic/parser/EditCommandParser.java
Outdated
Show resolved
Hide resolved
src/test/java/seedu/address/storage/JsonAdaptedPatientTest.java
Outdated
Show resolved
Hide resolved
Wong-ZZ
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #45
resolves #48
resolves #49
resolves #34
I think i might be missing some test cases