Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update certain fields to become optional #58

Merged

Conversation

PrestonTYR
Copy link

@PrestonTYR PrestonTYR commented Oct 7, 2020

resolves #45
resolves #48
resolves #49
resolves #34

I think i might be missing some test cases

@PrestonTYR PrestonTYR added this to the v1.2 milestone Oct 7, 2020
@PrestonTYR PrestonTYR changed the title Branch optional fields Update certain fields to become optional Oct 7, 2020
@codecov-io
Copy link

codecov-io commented Oct 8, 2020

Codecov Report

Merging #58 into master will decrease coverage by 3.50%.
The diff coverage is 52.22%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #58      +/-   ##
============================================
- Coverage     76.09%   72.59%   -3.51%     
- Complexity      492      498       +6     
============================================
  Files            77       78       +1     
  Lines          1523     1613      +90     
  Branches        171      188      +17     
============================================
+ Hits           1159     1171      +12     
- Misses          321      381      +60     
- Partials         43       61      +18     
Impacted Files Coverage Δ Complexity Δ
.../java/seedu/address/model/util/SampleDataUtil.java 10.00% <0.00%> (-10.00%) 1.00 <0.00> (ø)
src/main/java/seedu/address/ui/PatientCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...java/seedu/address/storage/JsonAdaptedPatient.java 75.75% <42.85%> (-24.25%) 17.00 <0.00> (-6.00)
...main/java/seedu/address/model/patient/Patient.java 86.53% <58.62%> (-11.09%) 36.00 <6.00> (+6.00) ⬇️
...java/seedu/address/logic/commands/EditCommand.java 97.95% <100.00%> (+0.02%) 12.00 <0.00> (ø)
...a/seedu/address/logic/parser/AddCommandParser.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 94.59% <100.00%> (ø) 16.00 <0.00> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 98.48% <100.00%> (+0.12%) 29.00 <15.00> (+5.00)
...a/seedu/address/model/medicalnote/MedicalNote.java 42.30% <0.00%> (ø) 6.00% <0.00%> (?%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b76903b...785abc5. Read the comment docs.

@Wong-ZZ Wong-ZZ merged commit a053ea6 into AY2021S1-CS2103T-F13-3:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment