Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GUI #108

Merged
Merged

Conversation

jonahtanjz
Copy link
Collaborator

  • Add popup when app is started to show expired food items
  • Add icons to attributes
  • Add headers to different lists
  • Limit Description to 50 characters and Tag to 72 characters
  • Wrap text on expiring food list
  • Display each Food attribute on new line in command result box

@jonahtanjz jonahtanjz added the type.Task A task - Something that needs to be done, but not a story, bug, or an epic label Oct 26, 2020
@jonahtanjz jonahtanjz added this to the v1.3 milestone Oct 26, 2020
@jonahtanjz jonahtanjz self-assigned this Oct 26, 2020
@jonahtanjz jonahtanjz added this to To Do in Week 11 via automation Oct 26, 2020
@codecov-io
Copy link

codecov-io commented Oct 26, 2020

Codecov Report

Merging #108 into master will decrease coverage by 2.11%.
The diff coverage is 27.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #108      +/-   ##
============================================
- Coverage     71.65%   69.54%   -2.12%     
- Complexity      531      536       +5     
============================================
  Files            84       87       +3     
  Lines          1690     1763      +73     
  Branches        197      198       +1     
============================================
+ Hits           1211     1226      +15     
- Misses          400      454      +54     
- Partials         79       83       +4     
Impacted Files Coverage Δ Complexity Δ
...seedu/simplykitchen/logic/commands/AddCommand.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
...du/simplykitchen/logic/commands/DeleteCommand.java 100.00% <ø> (ø) 7.00 <0.00> (ø)
...eedu/simplykitchen/logic/commands/EditCommand.java 97.05% <ø> (ø) 12.00 <0.00> (ø)
src/main/java/seedu/simplykitchen/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...va/seedu/simplykitchen/ui/ExpiredFoodListCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...a/seedu/simplykitchen/ui/ExpiredFoodListPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...java/seedu/simplykitchen/ui/ExpiredFoodWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../java/seedu/simplykitchen/ui/ExpiringFoodCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../seedu/simplykitchen/ui/ExpiringFoodListPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/main/java/seedu/simplykitchen/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c6d72c...695df6b. Read the comment docs.

@jonahtanjz jonahtanjz mentioned this pull request Oct 26, 2020
@jonahtanjz jonahtanjz linked an issue Oct 26, 2020 that may be closed by this pull request
@jonahtanjz jonahtanjz moved this from To Do to In Progress (Jonah) in Week 11 Oct 26, 2020
Copy link
Collaborator

@sagarsureka sagarsureka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sagarsureka sagarsureka merged commit b252426 into AY2021S1-CS2103T-F13-4:master Oct 27, 2020
Week 11 automation moved this from In Progress (Jonah) to Done Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Task A task - Something that needs to be done, but not a story, bug, or an epic
Projects
Week 11
  
Done
Development

Successfully merging this pull request may close these issues.

Improve GUI
3 participants