Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tags to Expired and Expiring Food List #173

Conversation

bchenghi
Copy link
Collaborator

@bchenghi bchenghi commented Nov 2, 2020

Close #141

  • Tags in expired and expiring lists
  • A tag's width is at most 0.9 of the width of the list, otherwise, it will wrap to next line

@bchenghi bchenghi added the type.Bug A bug label Nov 2, 2020
@bchenghi bchenghi added this to the v1.4 milestone Nov 2, 2020
@bchenghi bchenghi self-assigned this Nov 2, 2020
@bchenghi bchenghi added this to To Do in Week 12 via automation Nov 2, 2020
@bchenghi bchenghi moved this from To Do to In Progress (Cheng Hin) in Week 12 Nov 2, 2020
@bchenghi bchenghi added the type.Task A task - Something that needs to be done, but not a story, bug, or an epic label Nov 2, 2020
@codecov-io
Copy link

codecov-io commented Nov 2, 2020

Codecov Report

Merging #173 into master will decrease coverage by 0.68%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #173      +/-   ##
============================================
- Coverage     70.65%   69.97%   -0.69%     
  Complexity      585      585              
============================================
  Files            89       89              
  Lines          1847     1865      +18     
  Branches        207      207              
============================================
  Hits           1305     1305              
- Misses          454      472      +18     
  Partials         88       88              
Impacted Files Coverage Δ Complexity Δ
...va/seedu/simplykitchen/ui/ExpiredFoodListCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/seedu/simplykitchen/ui/ExpiringFoodCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1cf469...3816238. Read the comment docs.

Copy link
Collaborator

@rolandyuwy rolandyuwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahtanjz jonahtanjz merged commit 23d76be into AY2021S1-CS2103T-F13-4:master Nov 4, 2020
@rolandyuwy rolandyuwy moved this from In Progress (Cheng Hin) to Done (Bugs) in Week 12 Nov 4, 2020
@rolandyuwy rolandyuwy moved this from Done (Bugs) to Done (Enhancements) in Week 12 Nov 4, 2020
@rolandyuwy rolandyuwy moved this from Done (Enhancements) to Done in Week 12 Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Bug A bug type.Task A task - Something that needs to be done, but not a story, bug, or an epic
Projects
Week 12
  
Done
Development

Successfully merging this pull request may close these issues.

[PE-D] Expired food and expiring soon lists do not show tags
4 participants