-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Phone with Priority #50
Replace Phone with Priority #50
Conversation
jonahtanjz
commented
Sep 29, 2020
•
edited
edited
- Replace all instances of Phone with Priority
- Priority is optional in Add command, default to LOW if not specified
- Add colours to different priorities in UI
- Update JUnit test to work with Priority
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
============================================
- Coverage 72.31% 71.82% -0.49%
- Complexity 400 405 +5
============================================
Files 70 70
Lines 1228 1253 +25
Branches 124 126 +2
============================================
+ Hits 888 900 +12
- Misses 308 320 +12
- Partials 32 33 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look great! I added some comments below.
src/test/java/seedu/address/logic/commands/CommandTestUtil.java
Outdated
Show resolved
Hide resolved
src/test/java/seedu/address/logic/parser/AddCommandParserTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
LGTM |