Search feature implementation

[shaokiat]

Search Feature:

• Add ignoreCase method to StringUtil class to convert all arguments into all caps
• Add SearchCommand
• Add SearchCommandParser
• Add ModuleInfoSearcher

SearchCommand:
Uses ModuleInfoSearcher to perform search for ModuleInfo of the module being searched for.
Returns the string format of the module information to be displayed in the Command Line Interface.

SearchCommandParser:
Parse arguments and uses ignoreCase method of StringUtil to convert all arguments into proper moduleCode format before creating a SearchCommand.

ModuleInfoSearcher:
Contains logic to use NusmodsDataManager API and retrieve ModuleInfo from NUSMods or local saved file.

[yan-soon]

LGTM! Just some minor suggestions.

[yan-soon]

Maybe we can catch the possible IllegalArgumentException error thrown by the StringUtil.ignoreCase() method here so that we can display an error message to the user that something has gone wrong.

Currently if the user types in "search MA 1521", the IllegalArgumentException error is thrown in IntelliJ but not in the GUI. Maybe we can try something like that, but I'm not too sure what error message you would wanna show them hehe

Suggested change

	String moduleCode = StringUtil.ignoreCase(trimmedArgs);
	return new SearchCommand(moduleCode);
	try {
	String moduleCode = StringUtil.ignoreCase(trimmedArgs);
	return new SearchCommand(moduleCode);
	}
	catch (IllegalArgumentException e) {
	throw new ParseException(String.format(MESSAGE_INVALID_COMMAND_FORMAT, SearchCommand.MESSAGE_USAGE));
	}

[shaokiat]

Oh wow good catch! Added the relevant code!

[codecov-io]

Codecov Report

Merging #100 into master will increase coverage by 0.39%.
The diff coverage is 86.04%.

@@             Coverage Diff              @@
##             master     #100      +/-   ##
============================================
+ Coverage     72.58%   72.98%   +0.39%     
- Complexity      464      479      +15     
============================================
  Files            80       83       +3     
  Lines          1419     1462      +43     
  Branches        146      151       +5     
============================================
+ Hits           1030     1067      +37     
- Misses          312      317       +5     
- Partials         77       78       +1     

Impacted Files	Coverage Δ	Complexity Δ
...java/seedu/address/logic/parser/GradPadParser.java	77.27% <0.00%> (-3.68%)	13.00 <0.00> (ø)
...eedu/address/logic/parser/SearchCommandParser.java	77.77% <77.77%> (ø)	3.00 <3.00> (?)
...n/java/seedu/address/logic/ModuleInfoSearcher.java	84.61% <84.61%> (ø)	4.00 <4.00> (?)
...va/seedu/address/logic/commands/SearchCommand.java	93.75% <93.75%> (ø)	5.00 <5.00> (?)
...in/java/seedu/address/commons/util/StringUtil.java	95.23% <100.00%> (+1.12%)	10.00 <3.00> (+3.00)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f7d1aa...9675095. Read the comment docs.

[mhdsyfq77]

LRGTM! super well done 👍🏽 👍🏽

[Silvernitro]

Really really clean code bro 💯 Just a few really really minor comments :D

And although you asked about how to improve your testing, I actually think your testing is damn efficient man. Test coverage for the code you've written is almost 100% :O The only test gap is the test for the searchCommand branch in GradPadParser 😁