Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address UG peer review feedback #113

Merged
merged 3 commits into from
Oct 25, 2020
Merged

Address UG peer review feedback #113

merged 3 commits into from
Oct 25, 2020

Conversation

Silvernitro
Copy link

@Silvernitro Silvernitro commented Oct 25, 2020 •
edited

Changes as received during the CS2101 peer review:

  • Add a line separator between Intro and Quick Start
  • Add the purpose of the UG to the intro
  • Add an "example" column to the command summary table
  • Change any remaining third person language to "you"
  • Uncapitalize "Module Code" and "Modular Credits"
  • Minor changes to grammar, language, formatting bugs

As usual, you can view the latest changes here: https://silvernitro.github.io/tp/UserGuide.html

Closes #114

@Silvernitro Silvernitro added documentation Improvements or additions to documentation type.Task priority.Medium labels Oct 25, 2020
@Silvernitro Silvernitro added this to the v1.3 milestone Oct 25, 2020
@Silvernitro Silvernitro requested a review from a team October 25, 2020 06:57
@Silvernitro Silvernitro self-assigned this Oct 25, 2020
yan-soon
yan-soon approved these changes Oct 25, 2020
View reviewed changes
Copy link

@yan-soon yan-soon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yan-soon yan-soon merged commit ab673a3 into AY2021S1-CS2103T-T09-1:master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yan-soon yan-soon yan-soon approved these changes

Assignees

@Silvernitro Silvernitro

Labels
documentation Improvements or additions to documentation priority.Medium type.Task
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Address UG peer review feedback
2 participants
@Silvernitro @yan-soon